[lld] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used, last part. (PR #107615)
Daniil Fukalov via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 9 04:38:57 PDT 2024
dfukalov wrote:
> Right, it'll use whatever you have in your local build environment I believe (even simple things as NDEBUG depends if you have a release or assert build), I don't think it can do differently?
> I don't quite understand how adding this include changes **anything**? (I assume they are already transitively included right?)
The change is needed to go further with includes cleanup, like in PR #104825. Without these explicit includes it is too easy to remove implicitly included config headers even for a local config that is being built. And then it is hard to find where an include was transitively included. For a "non-local" config it is much more complicated.
https://github.com/llvm/llvm-project/pull/107615
More information about the llvm-commits
mailing list