[llvm] [Analysis] Avoid repeated hash lookups (NFC) (PR #107794)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 8 18:55:20 PDT 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/107794

None

>From e0bd73b3b493ba75fd147217ad5c1e97f2c39099 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 8 Sep 2024 09:54:05 -0700
Subject: [PATCH] [Analysis] Avoid repeated hash lookups (NFC)

---
 llvm/include/llvm/Analysis/DOTGraphTraitsPass.h | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h b/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
index 7aea7a3b0f6d69..ba5ee1d7db4871 100644
--- a/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
+++ b/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
@@ -91,12 +91,9 @@ static inline void shortenFileName(std::string &FN, unsigned char len = 250) {
     FN.resize(len);
   auto strLen = FN.length();
   while (strLen > 0) {
-    if (nameObj.find(FN) != nameObj.end()) {
-      FN.resize(--len);
-    } else {
-      nameObj.insert(FN);
+    if (nameObj.insert(FN).second)
       break;
-    }
+    FN.resize(--len);
     strLen--;
   }
 }



More information about the llvm-commits mailing list