[llvm] [TableGen] Migrate CTags/DFA/Directive Emitters to const RecordKeeper (PR #107693)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 7 22:06:03 PDT 2024


================
@@ -15,7 +15,8 @@ namespace llvm {
 // DirectiveBase.td and provides helper methods for accessing it.
 class DirectiveLanguage {
 public:
-  explicit DirectiveLanguage(llvm::RecordKeeper &Records) : Records(Records) {
+  explicit DirectiveLanguage(const llvm::RecordKeeper &Records)
----------------
jurahul wrote:

No, but I refrained from changing it. Apart from this, there are some other NFC cleanups that can be done in this file. For example, using {} instead of LLVM's recommended () for constructors. and other llvm:: that's not needed. How about I clean that up as a separate NFC?

https://github.com/llvm/llvm-project/pull/107693


More information about the llvm-commits mailing list