[llvm] 6f6100f - [Bitcode] Avoid repeated hash lookups (NFC) (#107708)

[via llvm-commits]

Author: Kazu Hirata
Date: 2024-09-07T11:23:15-07:00
New Revision: 6f6100f19ca1fc130a9c2bd2586d136805eafa89

URL: https://github.com/llvm/llvm-project/commit/6f6100f19ca1fc130a9c2bd2586d136805eafa89
DIFF: https://github.com/llvm/llvm-project/commit/6f6100f19ca1fc130a9c2bd2586d136805eafa89.diff

LOG: [Bitcode] Avoid repeated hash lookups (NFC) (#107708)

Added: 
    

Modified: 
    llvm/lib/Bitcode/Reader/MetadataLoader.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
index 7d7b224a17d3b8..5b3b63c2d1e4eb 100644
--- a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
+++ b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
@@ -536,9 +536,8 @@ class MetadataLoader::MetadataLoaderImpl {
     DenseSet<DILocalScope *> Visited;
     while (S && !isa<DISubprogram>(S)) {
       S = dyn_cast_or_null<DILocalScope>(S->getScope());
-      if (Visited.contains(S))
+      if (!Visited.insert(S).second)
         break;
-      Visited.insert(S);
     }
     ParentSubprogram[InitialScope] = llvm::dyn_cast_or_null<DISubprogram>(S);