[llvm] Support STRICT_UINT_TO_FP and STRICT_SINT_TO_FP (PR #102503)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 11:48:28 PDT 2024


================
@@ -3473,7 +3475,7 @@ bool DAGTypeLegalizer::SoftPromoteHalfOperand(SDNode *N, unsigned OpNo) {
 
   assert(Res.getNode() != N && "Expected a new node!");
 
-  assert(Res.getValueType() == N->getValueType(0) && N->getNumValues() == 1 &&
+  assert(Res.getValueType() == N->getValueType(0) &&
----------------
topperc wrote:

Right. Which is why I proposed changing the STRICT_FP_TO_SINT handling to return SDValue() and handle the ReplaceValue for result 0. Which is how this is usually handled. But that breaks the expand code. So I guess we can leave this.

https://github.com/llvm/llvm-project/pull/102503


More information about the llvm-commits mailing list