[llvm] [Minidump] Support multiple exceptions in a minidump (PR #107319)

Jacob Lalonde via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 09:04:20 PDT 2024


Jlalond wrote:

> > @labath As usual great review feedback, but I realized we have a slight issue with this patch. If we just change llvm in this PR, and not the LLDB call sites we will break the build. To simplify this, I'm going to keep the singular `getExceptionStream()` API, and then in the other patch remove that API + move LLDB to the new API.
> > Any concerns with this plan?
> 
> If a patch in one project requires changes to another project in order to keep that project building, then it's of course fine to include changes to the other project in the same PR. It's just that they should be kept as small as possible. The thing I want to avoid is making a complex change to one project _and_ simultaneously make a complex change (depending on the first one) in the other project and putting both on the same review.
> 
> So, I would be fine with making some sort of a minimal change to lldb (e.g. change it just enough to build and use a single exception stream) in this PR. Your approach (keeping the llvm interface until lldb is modified) is the same idea, but in the opposite direction, and it's also fine.

Appreciate it, my question was more for me to learn if there was any unforeseen issues I could run into either way. As I am still new to LLDB/LLVM I'm trying to absorb as much expertise as possible.

https://github.com/llvm/llvm-project/pull/107319


More information about the llvm-commits mailing list