[llvm] c9bdc25 - [X86][MC] Cont. update for AVX10.2-BF16 (#107529)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 04:30:13 PDT 2024


Author: Freddy Ye
Date: 2024-09-06T13:30:08+02:00
New Revision: c9bdc2564dabd1601ac0d714ba3f7057f55f6329

URL: https://github.com/llvm/llvm-project/commit/c9bdc2564dabd1601ac0d714ba3f7057f55f6329
DIFF: https://github.com/llvm/llvm-project/commit/c9bdc2564dabd1601ac0d714ba3f7057f55f6329.diff

LOG: [X86][MC] Cont. update for AVX10.2-BF16 (#107529)

Not an expert in this code, but looks like it fixed the crash for us. Picking it up.

Added: 
    

Modified: 
    llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
    llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
index 8fcc1c10d93a04..cb34b56fbb07a7 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
@@ -216,8 +216,6 @@ bool X86ATTInstPrinter::printVecCompareInstr(const MCInst *MI,
               printdwordmem(MI, CurOp--, OS);
           } else if ((Desc.TSFlags & X86II::OpPrefixMask) == X86II::XD &&
                      (Desc.TSFlags & X86II::OpMapMask) != X86II::TA) {
-            assert((Desc.TSFlags & X86II::OpMapMask) != X86II::TA &&
-                   "Unexpected op map!");
             printqwordmem(MI, CurOp--, OS);
           } else if (Desc.TSFlags & X86II::EVEX_L2) {
             printzmmwordmem(MI, CurOp--, OS);

diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
index 39600ffcadd8ee..0e00b4d0d5b160 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
@@ -204,9 +204,8 @@ bool X86IntelInstPrinter::printVecCompareInstr(const MCInst *MI, raw_ostream &OS
               printwordmem(MI, CurOp++, OS);
             else
               printdwordmem(MI, CurOp++, OS);
-          } else if ((Desc.TSFlags & X86II::OpPrefixMask) == X86II::XD) {
-            assert((Desc.TSFlags & X86II::OpMapMask) != X86II::TA &&
-                   "Unexpected op map!");
+          } else if ((Desc.TSFlags & X86II::OpPrefixMask) == X86II::XD &&
+                     (Desc.TSFlags & X86II::OpMapMask) != X86II::TA) {
             printqwordmem(MI, CurOp++, OS);
           } else if (Desc.TSFlags & X86II::EVEX_L2) {
             printzmmwordmem(MI, CurOp++, OS);


        


More information about the llvm-commits mailing list