[lld] [lld-macho][arm64] Enhance safe ICF with thunk-based deduplication (PR #106573)

Kyungwoo Lee via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 11:53:50 PDT 2024


================
@@ -41,6 +41,11 @@ class Symbol {
     AliasKind,
   };
 
+  // Enum that describes the kind of ICF folding that a symbol is involved in.
+  // We need to keep track of this to correctly display symbol sizes in the map
+  // file.
+  enum ICFFoldKind { None, Folded_Body, Folded_Thunk };
----------------
kyulee-com wrote:

The prefix `Folded_` seems redundant. Can you clarify the comments for each case something like:
```
	// Enum that describes the type of Identical Code Folding (ICF) applied to a symbol.
	// This information is crucial for accurately representing symbol sizes in the map file.
enum ICFFoldKind {
  None,    // No folding is applied.
  Body,    // The entire body (function or data) is folded.
  Thunk    // The function body is folded into a thunk.
};
```

https://github.com/llvm/llvm-project/pull/106573


More information about the llvm-commits mailing list