[llvm] Use TargetABI to assign default-target features in getDefaultSubtargetFeatures (PR #100833)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 17:33:12 PDT 2024


================
@@ -201,7 +201,12 @@ static std::unique_ptr<TargetMachine>
 createTargetMachine(const Config &Conf, const Target *TheTarget, Module &M) {
   StringRef TheTriple = M.getTargetTriple();
   SubtargetFeatures Features;
-  Features.getDefaultSubtargetFeatures(Triple(TheTriple));
+  StringRef TargetABI = "";
+  if (auto TargetABIMD =
----------------
topperc wrote:

I think this should be `auto *TargetABIMD`. Coding standards say to still make it obvious when something is a pointer.

https://github.com/llvm/llvm-project/pull/100833


More information about the llvm-commits mailing list