[lld] [LLD][COFF] Initial support for ARM64EC importlibs. (PR #107164)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 01:40:59 PDT 2024


================
@@ -1019,9 +1020,16 @@ void ImportFile::parse() {
 
   // Read names and create an __imp_ symbol.
   StringRef buf = mb.getBuffer().substr(sizeof(*hdr));
-  StringRef name = saver().save(buf.split('\0').first);
+  StringRef nameBuf = buf.split('\0').first, name;
----------------
mstorsjo wrote:

Stylistically, I dislike the `type var = initialization, otherVar;` style - if there's an initialization of one variable (and a nontrivial one in this case) I find it more readable to have the other variable on a separate line, or perhaps reordered so that the pure name without an assignment first.

https://github.com/llvm/llvm-project/pull/107164


More information about the llvm-commits mailing list