[llvm] [llvm/llvm-project][Coroutines] ABI Object (PR #106306)
Tyler Nowicki via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 3 22:48:18 PDT 2024
TylerNowicki wrote:
> This patch looks good. And the proposal looks good generally (it is long and maybe I missed some details).
>
> But the problem is.. it looks like the contents of the PR is less related to the message body. It may be confusing. And also, I think such proposal should be sent to https://discourse.llvm.org/ to get a wider visibility.
Sorry I may not have followed the BKM here for presenting the changes. If you look at the 'Proposed PRs' part of the proposal it has a list of PRs. I split it up into separate PRs because one giant PR would not be easy to review. The first PR is from a branch (A) in my forked repo to llvm's main. The second PRs is from another branch in my forked repo (B) to branch (A). And so on... So once branch (A) is merged to llvm's main then I will update the PR for (B) to point to llvm's main and that can be merged. This should allow each change's PR to be reviewed right now without merging any PRs. Can you recommend another method to present the changes (changes that build on each other one to the next) so they can be easily reviewed?
https://github.com/llvm/llvm-project/pull/106306
More information about the llvm-commits
mailing list