[llvm] [SROA] Use SetVector for PromotableAllocas (PR #105809)

[Nikita Popov via llvm-commits]

=?utf-8?q?Bartłomiej?= Chmiel <bchmiel at antmicro.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/105809 at github.com>


nikic wrote:

Does this version fully address the SROA scalability issue for you, or only partially?

I'd expect this version to be fast when removing elements that are not in the vector, but still equally slow if they are in the vector, as this requires a linear scan. Actually, that case may be even slower, because it will now do a linear scan per removed element, rather than one to remove all matching elements.

Is removing elements not in the vector the common case?

https://github.com/llvm/llvm-project/pull/105809