[compiler-rt] 0ef7b1d - [scudo] Update secondary cache released pages bound. (#106466)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 13:56:49 PDT 2024


Author: Joshua Baehring
Date: 2024-09-03T13:56:46-07:00
New Revision: 0ef7b1d21ca7ce55f1c8d3ec739e64775572e9cc

URL: https://github.com/llvm/llvm-project/commit/0ef7b1d21ca7ce55f1c8d3ec739e64775572e9cc
DIFF: https://github.com/llvm/llvm-project/commit/0ef7b1d21ca7ce55f1c8d3ec739e64775572e9cc.diff

LOG: [scudo] Update secondary cache released pages bound. (#106466)

`MaxReleasedCachePages` has been set to 4. Initially, in #105009 , we
set `MaxReleasedCachePages` to 0 so that the partial chunk heuristic
could be introduced incrementally as we observed its impact on retrieval
order and more generally, performance.

Co-authored-by: Joshua Baehring <josh.baehring at yale.edu>

Added: 
    

Modified: 
    compiler-rt/lib/scudo/standalone/secondary.h

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/scudo/standalone/secondary.h b/compiler-rt/lib/scudo/standalone/secondary.h
index fba21c3cb6a09d..1a232b9b9fb2d7 100644
--- a/compiler-rt/lib/scudo/standalone/secondary.h
+++ b/compiler-rt/lib/scudo/standalone/secondary.h
@@ -79,8 +79,7 @@ struct CachedBlock {
   //        it suggests that beyond 4 pages, the release execution time is
   //        longer than the map execution time. In this way, the default
   //        is dependent on the platform.
-  //    TODO: set MaxReleasedCachePages back to 4U
-  static constexpr uptr MaxReleasedCachePages = 0U;
+  static constexpr uptr MaxReleasedCachePages = 4U;
 
   uptr CommitBase = 0;
   uptr CommitSize = 0;


        


More information about the llvm-commits mailing list