[llvm] [GlobalIsel] Visit ICmp (PR #105991)

[Thorsten Schütt via llvm-commits]

tschuett wrote:

> Some more comments. Frankly I'm having trouble following some of your comments like this:
> 
> > IR is in perfect canonical state. Codegen may do some target specific optimizations, but I would be surprised if they move constants to the left. The IRTranslator faithfully translates IR into gMIR. Thus porting middle-end optimizations to the backend is a waste of time because they cannot give any size improvements.
> 
> Are you agreeing or disagreeing with your current patch? At this point I have no idea.

I am supportive of this patch. I was only stating the common assumption. But also the cmp x, 0 is at odds with this statement.

https://github.com/llvm/llvm-project/pull/105991