[llvm] [GlobalIsel] Visit ICmp (PR #105991)

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 10:08:28 PDT 2024


Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/105991 at github.com>


aemerson wrote:

Some more comments. Frankly I'm having trouble following some of your comments like this:
> IR is in perfect canonical state. Codegen may do some target specific optimizations, but I would be surprised if they move constants to the left. The IRTranslator faithfully translates IR into gMIR. Thus porting middle-end optimizations to the backend is a waste of time because they cannot give any size improvements.

Are you agreeing or disagreeing with your current patch? At this point I have no idea.

https://github.com/llvm/llvm-project/pull/105991


More information about the llvm-commits mailing list