[compiler-rt] [profile] Change __llvm_profile_counter_bias etc. types to match llvm (PR #102747)

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 00:32:34 PDT 2024


petrhosek wrote:

> I remain sceptical wrt. @petrhosek suggestion: while my patch trivially gets `clang` and `compiler-rt` in sync, his incompatibly changes the profile file format (for 32-bit targets) and requires considerably more effort to implement. Even if it could be implemented quickly (and I won't be able to do so), it's way too late and intrusive for the 19.x release. Maybe one of the other reviewers could chime in?

That's a fair point, I think it's too late to make such a large change for the 19.x release so I'm fine merging this change despite the potential performance regression (although that's a pre-existing issue), but I think we should file an issue to implement the proper solution after.

https://github.com/llvm/llvm-project/pull/102747


More information about the llvm-commits mailing list