[compiler-rt] [compiler-rt][rtsan] Record pc and bp higher up in the stack (PR #107014)

Chris Apple via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 15:01:11 PDT 2024


================
@@ -85,12 +89,13 @@ bool __rtsan::Context::InRealtimeContext() const { return realtime_depth_ > 0; }
 
 bool __rtsan::Context::IsBypassed() const { return bypass_depth_ > 0; }
 
-void __rtsan::PrintDiagnostics(const char *intercepted_function_name) {
+void __rtsan::PrintDiagnostics(const char *intercepted_function_name, uptr pc,
----------------
cjappl wrote:

The full names of these are "program counter" and "base pointer". We can use their full names, but it would be breaking with the rest of the code,

```
> rg "ProgramCounter|program_counter|programCounter"| wc -l
      11
> rg "uptr pc" | wc -l
     428
```

(The comparison with base pointer is a little harder to illustrate with a bulk search for this as the term is a little overloaded.)

https://github.com/llvm/llvm-project/pull/107014


More information about the llvm-commits mailing list