[llvm] [CodeGen] Distinguish zero-sized call frames from no call frame in MachineBB (PR #106964)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 2 07:18:21 PDT 2024


================
@@ -3837,11 +3837,11 @@ void MachineVerifier::verifyStackFrame() {
       BBState.ExitIsSetup = BBState.EntryIsSetup;
     }
 
-    if ((int)MBB->getCallFrameSize() != -BBState.EntryValue) {
+    if ((int)MBB->getCallFrameSizeOrZero() != -BBState.EntryValue) {
----------------
jayfoad wrote:

Could you improve the verification here by making EntryValue/ExitValue be std::optionals too, and using the to track the presence/absence of a call frame?

https://github.com/llvm/llvm-project/pull/106964


More information about the llvm-commits mailing list