[llvm] don't set TracePCGuard as the default (PR #106464)

via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 15:50:09 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-transforms

Author: Andrew Kelley (andrewrk)

<details>
<summary>Changes</summary>

This allows library users to disable TracePCGuard along with those other options.

This "default" logic belongs in Clang, not LLVM.

---
Full diff: https://github.com/llvm/llvm-project/pull/106464.diff


1 Files Affected:

- (modified) llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp (-4) 


``````````diff
diff --git a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
index 6a89cee9aaf6cc..383023e3660a5e 100644
--- a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
+++ b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
@@ -194,10 +194,6 @@ SanitizerCoverageOptions OverrideFromCL(SanitizerCoverageOptions Options) {
   Options.StackDepth |= ClStackDepth;
   Options.TraceLoads |= ClLoadTracing;
   Options.TraceStores |= ClStoreTracing;
-  if (!Options.TracePCGuard && !Options.TracePC &&
-      !Options.Inline8bitCounters && !Options.StackDepth &&
-      !Options.InlineBoolFlag && !Options.TraceLoads && !Options.TraceStores)
-    Options.TracePCGuard = true; // TracePCGuard is default.
   Options.CollectControlFlow |= ClCollectCF;
   return Options;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/106464


More information about the llvm-commits mailing list