[llvm] don't set TracePCGuard as the default (PR #106464)

Andrew Kelley via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 15:49:41 PDT 2024


https://github.com/andrewrk created https://github.com/llvm/llvm-project/pull/106464

This allows library users to disable TracePCGuard along with those other options.

This "default" logic belongs in Clang, not LLVM.

>From 4ff8c7cb52dca63324463c0f6afcf4a332ed1225 Mon Sep 17 00:00:00 2001
From: Andrew Kelley <andrew at ziglang.org>
Date: Wed, 28 Aug 2024 15:48:27 -0700
Subject: [PATCH] don't set TracePCGuard as the default

This allows library users to disable TracePCGuard along with those other
options.

This "default" logic belongs in Clang, not LLVM.
---
 llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
index 6a89cee9aaf6cc..383023e3660a5e 100644
--- a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
+++ b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
@@ -194,10 +194,6 @@ SanitizerCoverageOptions OverrideFromCL(SanitizerCoverageOptions Options) {
   Options.StackDepth |= ClStackDepth;
   Options.TraceLoads |= ClLoadTracing;
   Options.TraceStores |= ClStoreTracing;
-  if (!Options.TracePCGuard && !Options.TracePC &&
-      !Options.Inline8bitCounters && !Options.StackDepth &&
-      !Options.InlineBoolFlag && !Options.TraceLoads && !Options.TraceStores)
-    Options.TracePCGuard = true; // TracePCGuard is default.
   Options.CollectControlFlow |= ClCollectCF;
   return Options;
 }



More information about the llvm-commits mailing list