[llvm] [bazel] Enable more lit self tests (PR #104285)

Keith Smiley via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 15:01:23 PDT 2024


https://github.com/keith created https://github.com/llvm/llvm-project/pull/104285

I assume the intent of the initial `*/*.py` was to also collect things
in `*.py`, but that's not what bazel does unless you use `**/*.py` which
is what we're doing now. A few of these tests fail so I explicitly
disabled them until someone has time to debug.


>From 9b5583e77f979dc881d1c3d427a93844c35d59ba Mon Sep 17 00:00:00 2001
From: Keith Smiley <keithbsmiley at gmail.com>
Date: Wed, 14 Aug 2024 22:00:09 +0000
Subject: [PATCH] [bazel] Enable more lit self tests

I assume the intent of the initial `*/*.py` was to also collect things
in `*.py`, but that's not what bazel does unless you use `**/*.py` which
is what we're doing now. A few of these tests fail so I explicitly
disabled them until someone has time to debug.
---
 .../llvm/utils/lit/tests/BUILD.bazel                  | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/llvm/utils/lit/tests/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/utils/lit/tests/BUILD.bazel
index 13f6f815d3995..d89626a6ee9e6 100644
--- a/utils/bazel/llvm-project-overlay/llvm/utils/lit/tests/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/utils/lit/tests/BUILD.bazel
@@ -34,7 +34,14 @@ expand_template(
         ] + glob(["Inputs/**"]),
     )
     for src in glob(
-        ["*/*.py"],
-        exclude = ["Inputs/**"],
+        ["**/*.py"],
+        exclude = [
+            "Inputs/**",
+            "discovery.py",  # TODO: debug and re-enable
+            "max-time.py",
+            "selecting.py",
+            "shtest-recursive-substitution.py",
+            "use-llvm-tool.py",
+        ],
     )
 ]



More information about the llvm-commits mailing list