[llvm] [llvm-lit] Resolve env subcommand required error (PR #98414)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 00:42:28 PDT 2024


Harini0924 wrote:

@jh7370 To clarify the changes I made: Originally, when the tests were failing, there was a check for errors using the line `# CHECK: # error: command failed with exit status: {{.*}}`. However, since the tests have been modified and are now passing, I replaced that check with `# CHECK-NOT: {{^[^#]}}`. This change reflects the fact that the tests are no longer expecting an error, but rather verifying that no unexpected output is generated.

Given this, I think it makes sense to maintain the original format for passing tests, which is `# CHECK-NOT: {{^[^#]}}`, instead of `# CHECK-NOT: # error:`. Does this approach make sense to you, or do you have any thoughts on changing this? If this makes sense, I can revert the last commit and use `# CHECK-NOT: {{^[^#]}}` consistently for the tests that pass. Please let me know if I should clarify anything further.

https://github.com/llvm/llvm-project/pull/98414


More information about the llvm-commits mailing list