[llvm] [llvm-lit] Resolve env subcommand required error (PR #98414)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 8 01:21:17 PDT 2024
jh7370 wrote:
> @jh7370 @arichardson I've changed `# CHECK-NOT: {{^[^#]}}` to `# CHECK-NOT: # error:` for the tests I modified. To maintain consistency across the whole file, should update the other passing tests to use `# CHECK-NOT: # error:` as well?
Generally, I'd avoid making consistency changes in the same PR, and make them in a follow-up instead.
That being said, I'm wondering if the intent of the other lines wasn't to check specifically for an error, but rather to check for any executed command output at all? Unfortunately, I'm not really familiar with this test or its background. I'd be reluctant to change what the test is really checking for without understanding its purpose.
https://github.com/llvm/llvm-project/pull/98414
More information about the llvm-commits
mailing list