[compiler-rt] 26552e4 - [ASan] Fix goo.gl link in comment for MSVC bug

Sam James via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 15:50:09 PDT 2024


Author: Sam James
Date: 2024-08-02T23:48:45+01:00
New Revision: 26552e47af803321ca9604936294cdea7e8d90c8

URL: https://github.com/llvm/llvm-project/commit/26552e47af803321ca9604936294cdea7e8d90c8
DIFF: https://github.com/llvm/llvm-project/commit/26552e47af803321ca9604936294cdea7e8d90c8.diff

LOG: [ASan] Fix goo.gl link in comment for MSVC bug

goo.gl is going away: https://developers.googleblog.com/en/google-url-shortener-links-will-no-longer-be-available/

Fix goo.gl link from:
- http://goo.gl/L4qqUG
+ https://connect.microsoft.com/VisualStudio/feedback/details/829931/vs2012-and-vs2013-istream-code-reads-off-the-end-of-its-non-null-terminated-stack-copied-string via archive.org

Endilll points out on the bug that the goo.gl link first goes to a dead
redirect to connect.microsoft.com, then to bing, so grab the article
from archive.org.

Committed as obvious.

Bug: https://github.com/llvm/llvm-project/issues/99586

Added: 
    

Modified: 
    compiler-rt/lib/asan/asan_ignorelist.txt

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/asan/asan_ignorelist.txt b/compiler-rt/lib/asan/asan_ignorelist.txt
index 5ce59926ce2f3..9134a63bc3b92 100644
--- a/compiler-rt/lib/asan/asan_ignorelist.txt
+++ b/compiler-rt/lib/asan/asan_ignorelist.txt
@@ -9,5 +9,6 @@
 # global:*global_with_initialization_issues*=init
 # type:*Namespace::ClassName*=init
 
-# Stack buffer overflow in VC/INCLUDE/xlocnum, see http://goo.gl/L4qqUG
+# Stack buffer overflow in VC/INCLUDE/xlocnum, see
+# https://web.archive.org/web/20140729123024/https://connect.microsoft.com/VisualStudio/feedback/details/829931/vs2012-and-vs2013-istream-code-reads-off-the-end-of-its-non-null-terminated-stack-copied-string
 fun:*_Find_elem@*@std*


        


More information about the llvm-commits mailing list