[compiler-rt] [NFC][asan] Report DynInitUnPoison (PR #101586)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 14:03:24 PDT 2024


https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/101586

>From 3d1739cdc018af4686a1b91765ece6c06acfed64 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at google.com>
Date: Thu, 1 Aug 2024 16:08:10 -0700
Subject: [PATCH] [NFC][asan] Report DynInitUnPoison

Pull Request: https://github.com/llvm/llvm-project/pull/101586
---
 compiler-rt/lib/asan/asan_globals.cpp                    | 3 ++-
 compiler-rt/test/asan/TestCases/initialization-nobug.cpp | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/compiler-rt/lib/asan/asan_globals.cpp b/compiler-rt/lib/asan/asan_globals.cpp
index 78f3a182993d1..cc5308a24fe89 100644
--- a/compiler-rt/lib/asan/asan_globals.cpp
+++ b/compiler-rt/lib/asan/asan_globals.cpp
@@ -477,7 +477,8 @@ void __asan_after_dynamic_init() {
     return;
   CHECK(AsanInited());
   Lock lock(&mu_for_globals);
-  // FIXME: Optionally report that we're unpoisoning globals from a module.
+  if (flags()->report_globals >= 3)
+    Printf("DynInitUnpoison\n");
   for (const DynInitGlobal &dyn_g : dynamic_init_globals) {
     const Global *g = &dyn_g.g;
     if (!dyn_g.initialized) {
diff --git a/compiler-rt/test/asan/TestCases/initialization-nobug.cpp b/compiler-rt/test/asan/TestCases/initialization-nobug.cpp
index 18bd3d764c74a..5659db088096b 100644
--- a/compiler-rt/test/asan/TestCases/initialization-nobug.cpp
+++ b/compiler-rt/test/asan/TestCases/initialization-nobug.cpp
@@ -44,4 +44,6 @@ int getStructWithDtorValue() { return struct_with_dtor.value; }
 int main() { return 0; }
 
 // CHECK: DynInitPoison module: {{.*}}initialization-nobug.cpp
+// CHECK: DynInitUnpoison
 // CHECK: DynInitPoison module: {{.*}}initialization-nobug-extra.cpp
+// CHECK: DynInitUnpoison



More information about the llvm-commits mailing list