[llvm] [gSYM] Add support merged functions in gSYM format (PR #101604)

Greg Clayton via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 13:51:26 PDT 2024


clayborg wrote:

> > do we want to try and only enable this if we see the new DWARF attribute
> 
> On the Mach-O side, this behavior has to be intentionally requested by passing "--keep-icf-stabs", it won't just be the default. 

Does `--keep-icf-stabs` enable our new attribute?

We might want a flag to llvm-gsymutil that enabled merged functions and it must be specified manually to get this info included. Otherwise the size of some gSYM file might increase by a lot

> For ELF, I am not sure if this will become the default, but I suspect not. Are there any other scenarios we should consider ?

We either need to auto detect from llvm-gsymutil if we should enable this, or enable it manually via an extra option to llvm-gsymutil

> Either way, should we have this behavior under a flag ? 

yes, I think we should mainly because this can increase the size of the GSYM file.

> Since actually using the information will require gSYM clients to provide additional callstack information during address resolution - do we want to enable creating gSYM's without this information, so that if someone is not using the feature, the additional data will not be included, since it's not going to be used anyway ?

It won't require anything right now, clients can get all the results back and then figure the info out themselves right?





https://github.com/llvm/llvm-project/pull/101604


More information about the llvm-commits mailing list