[llvm] [llvm-lit] Unhashable TypeError Support (PR #101590)

Paul Kirth via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 18:50:07 PDT 2024


https://github.com/ilovepi commented:

Please update the PR title to reflect what you are fixing/doing. This PR doesn't add support for Unhashable TypeErrors, it's trying to fix the manifestation of a TypeError in lit's python code. Additionally, please update the description to describe what you are fixing, and summarize the core changes you're making.

In this case, when using the internal shell, you're fixing a type mismatch when using certain builtins, because the GlobItem type doesn't implement hashable. As a workaround you've expanded the glob to avoid the error without additional code changes.

https://github.com/llvm/llvm-project/pull/101590


More information about the llvm-commits mailing list