[clang] [llvm] [Clang] Fix nomerge attribute not working with __builtin_trap(), __debugbreak(), __builtin_verbose_trap() (PR #101549)
Zequan Wu via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 1 13:13:37 PDT 2024
ZequanWu wrote:
> Richard had a comment on the original which I think it still relevant:
>
> > There are 496 calls to Builder.CreateCall in clang's CodeGen. Do they all need this change? If not, how can we be confident we've found all the ones that do? (From a quick check, at least MSVC's __fastfail builtin seems like it would also benefit from this handling.)
> > Would it be reasonable to make clang's CGBuilder do this for every call instruction we create?
>
> I think we could still do this, but we should fix this long outstanding bug first.
Yeah, it would be easier if there's one place to attach statement attributes on all expressions inside that statement.
https://github.com/llvm/llvm-project/pull/101549
More information about the llvm-commits
mailing list