[llvm] [InstCombine] Remove transformation on call instruction where return value need void to non-void conversion (PR #98536)

[Nikita Popov via llvm-commits]

================
@@ -4233,9 +4231,6 @@ bool InstCombinerImpl::transformConstExprCastCall(CallBase &Call) {
 
   AttributeSet FnAttrs = CallerPAL.getFnAttrs();
 
-  if (NewRetTy->isVoidTy())
-    Caller->setName("");   // Void type should not have a name.
----------------
nikic wrote:

I think this bit might still be needed? Can you please add another function to your test that does `%res = call i32 @foo()` but does not use the result? Just want to make sure this doesn't hit some void name assertion.

https://github.com/llvm/llvm-project/pull/98536