[llvm] StructurizeCFG: Optimize phi insertion during ssa reconstruction (PR #101301)

Sameer Sahasrabuddhe via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 07:47:32 PDT 2024


================
@@ -710,10 +714,114 @@ void StructurizeCFG::findUndefBlocks(
   }
 }
 
+// Return true if two PHI nodes have compatible incoming values (for each
+// incoming block, either they have the same incoming value or only one PHI
+// node has a incoming value). And return the union of the incoming values
+// through \p Merged.
+bool StructurizeCFG::isCompatible(const BBValueVector &IncomingA,
----------------
ssahasra wrote:

The function name is misleading because it sounds like a predicate, but it actually has a side-effect. Maybe call it `mergeIfCompatible()`?

https://github.com/llvm/llvm-project/pull/101301


More information about the llvm-commits mailing list