[llvm] [LowerMatrixIntrinsics] Fix type suffix for matrix.multiply.* (PR #100940)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 03:47:31 PDT 2024


fhahn wrote:

> @fhahn
> 
> Thank you for the approval!
> 
> I agree that it would be great if the verifier could detect such places, and I am interested in extending it to catch these violations. However, I am not very familiar with the internals of LLVM, so it might take me some time to investigate and implement improvements.
> 

There are already verifier checks for matrix intrinsics here: https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Verifier.cpp#L5992

Not sure how to get the mangled types for the intrinsic though.

> By the way, as mentioned above in the thread, I have turned off the "Keep my email addresses private" setting in response to the GitHub Actions bot's message. Is there anything else I need to do? (Do I need to rebase or anything else?)

I think that should be good now.

https://github.com/llvm/llvm-project/pull/100940


More information about the llvm-commits mailing list