[llvm] [ELFAttributeParser][NFC] Make string array arguments `const` (PR #101460)

via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 00:58:13 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7088a5ed880f29129ec844c66068e8cb61ca98bf e717da2013c583d883cd143e898bddc8d6fae6ff --extensions cpp -- llvm/lib/Support/ARMAttributeParser.cpp llvm/lib/Support/CSKYAttributeParser.cpp llvm/lib/Support/MSP430AttributeParser.cpp llvm/lib/Support/RISCVAttributeParser.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Support/ARMAttributeParser.cpp b/llvm/lib/Support/ARMAttributeParser.cpp
index b46ed2435e..43a11730b6 100644
--- a/llvm/lib/Support/ARMAttributeParser.cpp
+++ b/llvm/lib/Support/ARMAttributeParser.cpp
@@ -84,12 +84,29 @@ Error ARMAttributeParser::stringAttribute(AttrType tag) {
   return Error::success();
 }
 
-static const char *const CPU_arch_strings[] = {
-    "Pre-v4", "ARM v4", "ARM v4T", "ARM v5T", "ARM v5TE", "ARM v5TEJ",
-    "ARM v6", "ARM v6KZ", "ARM v6T2", "ARM v6K", "ARM v7", "ARM v6-M",
-    "ARM v6S-M", "ARM v7E-M", "ARM v8-A", "ARM v8-R", "ARM v8-M Baseline",
-    "ARM v8-M Mainline", nullptr, nullptr, nullptr, "ARM v8.1-M Mainline",
-    "ARM v9-A"};
+static const char *const CPU_arch_strings[] = {"Pre-v4",
+                                               "ARM v4",
+                                               "ARM v4T",
+                                               "ARM v5T",
+                                               "ARM v5TE",
+                                               "ARM v5TEJ",
+                                               "ARM v6",
+                                               "ARM v6KZ",
+                                               "ARM v6T2",
+                                               "ARM v6K",
+                                               "ARM v7",
+                                               "ARM v6-M",
+                                               "ARM v6S-M",
+                                               "ARM v7E-M",
+                                               "ARM v8-A",
+                                               "ARM v8-R",
+                                               "ARM v8-M Baseline",
+                                               "ARM v8-M Mainline",
+                                               nullptr,
+                                               nullptr,
+                                               nullptr,
+                                               "ARM v8.1-M Mainline",
+                                               "ARM v9-A"};
 
 Error ARMAttributeParser::CPU_arch(AttrType tag) {
   return parseStringAttribute("CPU_arch", tag, ArrayRef(CPU_arch_strings));
@@ -118,8 +135,8 @@ Error ARMAttributeParser::ARM_ISA_use(AttrType tag) {
 }
 
 Error ARMAttributeParser::THUMB_ISA_use(AttrType tag) {
-  static const char *const strings[] = {
-    "Not Permitted", "Thumb-1", "Thumb-2", "Permitted"};
+  static const char *const strings[] = {"Not Permitted", "Thumb-1", "Thumb-2",
+                                        "Permitted"};
   return parseStringAttribute("THUMB_ISA_use", tag, ArrayRef(strings));
 }
 
@@ -148,9 +165,14 @@ Error ARMAttributeParser::MVE_arch(AttrType tag) {
 }
 
 Error ARMAttributeParser::PCS_config(AttrType tag) {
-  static const char *const strings[] = {
-    "None", "Bare Platform", "Linux Application", "Linux DSO", "Palm OS 2004",
-    "Reserved (Palm OS)", "Symbian OS 2004", "Reserved (Symbian OS)"};
+  static const char *const strings[] = {"None",
+                                        "Bare Platform",
+                                        "Linux Application",
+                                        "Linux DSO",
+                                        "Palm OS 2004",
+                                        "Reserved (Palm OS)",
+                                        "Symbian OS 2004",
+                                        "Reserved (Symbian OS)"};
   return parseStringAttribute("PCS_config", tag, ArrayRef(strings));
 }
 
@@ -271,9 +293,9 @@ Error ARMAttributeParser::ABI_WMMX_args(AttrType tag) {
 
 Error ARMAttributeParser::ABI_optimization_goals(AttrType tag) {
   static const char *const strings[] = {
-    "None", "Speed", "Aggressive Speed", "Size", "Aggressive Size", "Debugging",
-    "Best Debugging"
-  };
+      "None",          "Speed",           "Aggressive Speed",
+      "Size",          "Aggressive Size", "Debugging",
+      "Best Debugging"};
   return parseStringAttribute("ABI_optimization_goals", tag, ArrayRef(strings));
 }
 
@@ -349,20 +371,20 @@ Error ARMAttributeParser::T2EE_use(AttrType tag) {
 
 Error ARMAttributeParser::Virtualization_use(AttrType tag) {
   static const char *const strings[] = {
-    "Not Permitted", "TrustZone", "Virtualization Extensions",
-    "TrustZone + Virtualization Extensions"};
+      "Not Permitted", "TrustZone", "Virtualization Extensions",
+      "TrustZone + Virtualization Extensions"};
   return parseStringAttribute("Virtualization_use", tag, ArrayRef(strings));
 }
 
 Error ARMAttributeParser::PAC_extension(ARMBuildAttrs::AttrType tag) {
-  static const char *const strings[] = {
-    "Not Permitted", "Permitted in NOP space", "Permitted"};
+  static const char *const strings[] = {"Not Permitted",
+                                        "Permitted in NOP space", "Permitted"};
   return parseStringAttribute("PAC_extension", tag, ArrayRef(strings));
 }
 
 Error ARMAttributeParser::BTI_extension(ARMBuildAttrs::AttrType tag) {
-  static const char *const strings[] = {
-    "Not Permitted", "Permitted in NOP space", "Permitted"};
+  static const char *const strings[] = {"Not Permitted",
+                                        "Permitted in NOP space", "Permitted"};
   return parseStringAttribute("BTI_extension", tag, ArrayRef(strings));
 }
 
diff --git a/llvm/lib/Support/MSP430AttributeParser.cpp b/llvm/lib/Support/MSP430AttributeParser.cpp
index 4b857a3093..27694b8f60 100644
--- a/llvm/lib/Support/MSP430AttributeParser.cpp
+++ b/llvm/lib/Support/MSP430AttributeParser.cpp
@@ -31,12 +31,14 @@ Error MSP430AttributeParser::parseCodeModel(AttrType Tag) {
 }
 
 Error MSP430AttributeParser::parseDataModel(AttrType Tag) {
-  static const char *const StringVals[] = {"None", "Small", "Large", "Restricted"};
+  static const char *const StringVals[] = {"None", "Small", "Large",
+                                           "Restricted"};
   return parseStringAttribute("Data Model", Tag, ArrayRef(StringVals));
 }
 
 Error MSP430AttributeParser::parseEnumSize(AttrType Tag) {
-  static const char *const StringVals[] = {"None", "Small", "Integer", "Don't Care"};
+  static const char *const StringVals[] = {"None", "Small", "Integer",
+                                           "Don't Care"};
   return parseStringAttribute("Enum Size", Tag, ArrayRef(StringVals));
 }
 
diff --git a/llvm/lib/Support/RISCVAttributeParser.cpp b/llvm/lib/Support/RISCVAttributeParser.cpp
index 551c6bc29f..20392e4bae 100644
--- a/llvm/lib/Support/RISCVAttributeParser.cpp
+++ b/llvm/lib/Support/RISCVAttributeParser.cpp
@@ -50,7 +50,8 @@ Error RISCVAttributeParser::atomicAbi(unsigned Tag) {
 }
 
 Error RISCVAttributeParser::unalignedAccess(unsigned tag) {
-  static const char *const strings[] = {"No unaligned access", "Unaligned access"};
+  static const char *const strings[] = {"No unaligned access",
+                                        "Unaligned access"};
   return parseStringAttribute("Unaligned_access", tag, ArrayRef(strings));
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/101460


More information about the llvm-commits mailing list