[llvm] [SimplifyLibCalls] Constant fold nan libcall (PR #101459)

Yingwei Zheng via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 00:31:28 PDT 2024


https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/101459

>From ff7d0e60d9a3059fd78e48eb557a5a6c35605df7 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng <dtcxzyw2333 at gmail.com>
Date: Thu, 1 Aug 2024 15:15:57 +0800
Subject: [PATCH 1/2] [SimplifyLibCalls] Constant fold nan libcall

---
 .../lib/Transforms/Utils/SimplifyLibCalls.cpp | 20 +++++++++
 llvm/test/Transforms/InstCombine/nan.ll       | 41 +++++++++++++++++++
 .../test/Transforms/InstCombine/nanl-fp128.ll | 32 +++++++++++++++
 llvm/test/Transforms/InstCombine/nanl-fp80.ll | 32 +++++++++++++++
 .../Transforms/InstCombine/nanl-ppc-fp128.ll  | 32 +++++++++++++++
 5 files changed, 157 insertions(+)
 create mode 100644 llvm/test/Transforms/InstCombine/nan.ll
 create mode 100644 llvm/test/Transforms/InstCombine/nanl-fp128.ll
 create mode 100644 llvm/test/Transforms/InstCombine/nanl-fp80.ll
 create mode 100644 llvm/test/Transforms/InstCombine/nanl-ppc-fp128.ll

diff --git a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
index 4100471eaaa1d..948e510be5c32 100644
--- a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
+++ b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
@@ -3858,6 +3858,22 @@ Value *LibCallSimplifier::optimizeStringMemoryLibCall(CallInst *CI,
   return nullptr;
 }
 
+/// Constant folding nan/nanf/nanl.
+static Value *optimizeNaN(CallInst *CI) {
+  StringRef CharSeq;
+  if (!getConstantStringInfo(CI->getArgOperand(0), CharSeq))
+    return nullptr;
+
+  llvm::APInt Fill;
+  // Treat empty strings as if they were zero.
+  if (CharSeq.empty())
+    Fill = llvm::APInt(32, 0);
+  else if (CharSeq.getAsInteger(0, Fill))
+    return nullptr;
+
+  return ConstantFP::getQNaN(CI->getType(), /*Negative=*/false, &Fill);
+}
+
 Value *LibCallSimplifier::optimizeFloatingPointLibCall(CallInst *CI,
                                                        LibFunc Func,
                                                        IRBuilderBase &Builder) {
@@ -3972,6 +3988,10 @@ Value *LibCallSimplifier::optimizeFloatingPointLibCall(CallInst *CI,
   case LibFunc_remquof:
   case LibFunc_remquol:
     return optimizeRemquo(CI, Builder);
+  case LibFunc_nan:
+  case LibFunc_nanf:
+  case LibFunc_nanl:
+    return optimizeNaN(CI);
   default:
     return nullptr;
   }
diff --git a/llvm/test/Transforms/InstCombine/nan.ll b/llvm/test/Transforms/InstCombine/nan.ll
new file mode 100644
index 0000000000000..fd4119bc0c06a
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/nan.ll
@@ -0,0 +1,41 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+ at empty = private unnamed_addr constant [1 x i8] zeroinitializer, align 1
+ at dec = private unnamed_addr constant [2 x i8] c"1\00", align 1
+ at hex = private unnamed_addr constant [4 x i8] c"0xf\00", align 1
+
+define double @nan_empty() {
+; CHECK-LABEL: define double @nan_empty() {
+; CHECK-NEXT:    ret double 0x7FF8000000000000
+;
+  %res = call double @nan(ptr @empty)
+  ret double %res
+}
+
+define double @nan_dec() {
+; CHECK-LABEL: define double @nan_dec() {
+; CHECK-NEXT:    ret double 0x7FF8000000000001
+;
+  %res = call double @nan(ptr @dec)
+  ret double %res
+}
+
+define double @nan_hex() {
+; CHECK-LABEL: define double @nan_hex() {
+; CHECK-NEXT:    ret double 0x7FF800000000000F
+;
+  %res = call double @nan(ptr @hex)
+  ret double %res
+}
+
+define float @nanf_empty() {
+; CHECK-LABEL: define float @nanf_empty() {
+; CHECK-NEXT:    ret float 0x7FF8000000000000
+;
+  %res = call float @nanf(ptr @empty)
+  ret float %res
+}
+
+declare float @nanf(ptr)
+declare double @nan(ptr)
diff --git a/llvm/test/Transforms/InstCombine/nanl-fp128.ll b/llvm/test/Transforms/InstCombine/nanl-fp128.ll
new file mode 100644
index 0000000000000..21ba0fb14ca20
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/nanl-fp128.ll
@@ -0,0 +1,32 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+ at empty = private unnamed_addr constant [1 x i8] zeroinitializer, align 1
+ at dec = private unnamed_addr constant [2 x i8] c"1\00", align 1
+ at hex = private unnamed_addr constant [4 x i8] c"0xf\00", align 1
+
+define fp128 @nanl_empty() {
+; CHECK-LABEL: define fp128 @nanl_empty() {
+; CHECK-NEXT:    ret fp128 0xL00000000000000007FFF800000000000
+;
+  %res = call fp128 @nanl(ptr @empty)
+  ret fp128 %res
+}
+
+define fp128 @nanl_dec() {
+; CHECK-LABEL: define fp128 @nanl_dec() {
+; CHECK-NEXT:    ret fp128 0xL00000000000000017FFF800000000000
+;
+  %res = call fp128 @nanl(ptr @dec)
+  ret fp128 %res
+}
+
+define fp128 @nanl_hex() {
+; CHECK-LABEL: define fp128 @nanl_hex() {
+; CHECK-NEXT:    ret fp128 0xL000000000000000F7FFF800000000000
+;
+  %res = call fp128 @nanl(ptr @hex)
+  ret fp128 %res
+}
+
+declare fp128 @nanl(ptr)
diff --git a/llvm/test/Transforms/InstCombine/nanl-fp80.ll b/llvm/test/Transforms/InstCombine/nanl-fp80.ll
new file mode 100644
index 0000000000000..7868af3696a56
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/nanl-fp80.ll
@@ -0,0 +1,32 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+ at empty = private unnamed_addr constant [1 x i8] zeroinitializer, align 1
+ at dec = private unnamed_addr constant [2 x i8] c"1\00", align 1
+ at hex = private unnamed_addr constant [4 x i8] c"0xf\00", align 1
+
+define x86_fp80 @nanl_empty() {
+; CHECK-LABEL: define x86_fp80 @nanl_empty() {
+; CHECK-NEXT:    ret x86_fp80 0xK7FFFC000000000000000
+;
+  %res = call x86_fp80 @nanl(ptr @empty)
+  ret x86_fp80 %res
+}
+
+define x86_fp80 @nanl_dec() {
+; CHECK-LABEL: define x86_fp80 @nanl_dec() {
+; CHECK-NEXT:    ret x86_fp80 0xK7FFFC000000000000001
+;
+  %res = call x86_fp80 @nanl(ptr @dec)
+  ret x86_fp80 %res
+}
+
+define x86_fp80 @nanl_hex() {
+; CHECK-LABEL: define x86_fp80 @nanl_hex() {
+; CHECK-NEXT:    ret x86_fp80 0xK7FFFC00000000000000F
+;
+  %res = call x86_fp80 @nanl(ptr @hex)
+  ret x86_fp80 %res
+}
+
+declare x86_fp80 @nanl(ptr)
diff --git a/llvm/test/Transforms/InstCombine/nanl-ppc-fp128.ll b/llvm/test/Transforms/InstCombine/nanl-ppc-fp128.ll
new file mode 100644
index 0000000000000..7f60a379c4885
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/nanl-ppc-fp128.ll
@@ -0,0 +1,32 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+ at empty = private unnamed_addr constant [1 x i8] zeroinitializer, align 1
+ at dec = private unnamed_addr constant [2 x i8] c"1\00", align 1
+ at hex = private unnamed_addr constant [4 x i8] c"0xf\00", align 1
+
+define ppc_fp128 @nanl_empty() {
+; CHECK-LABEL: define ppc_fp128 @nanl_empty() {
+; CHECK-NEXT:    ret ppc_fp128 0xM7FF80000000000000000000000000000
+;
+  %res = call ppc_fp128 @nanl(ptr @empty)
+  ret ppc_fp128 %res
+}
+
+define ppc_fp128 @nanl_dec() {
+; CHECK-LABEL: define ppc_fp128 @nanl_dec() {
+; CHECK-NEXT:    ret ppc_fp128 0xM7FF80000000000010000000000000000
+;
+  %res = call ppc_fp128 @nanl(ptr @dec)
+  ret ppc_fp128 %res
+}
+
+define ppc_fp128 @nanl_hex() {
+; CHECK-LABEL: define ppc_fp128 @nanl_hex() {
+; CHECK-NEXT:    ret ppc_fp128 0xM7FF800000000000F0000000000000000
+;
+  %res = call ppc_fp128 @nanl(ptr @hex)
+  ret ppc_fp128 %res
+}
+
+declare ppc_fp128 @nanl(ptr)

>From f92cb106a2a28486ee8b434cee5138ac6bc222fe Mon Sep 17 00:00:00 2001
From: Yingwei Zheng <dtcxzyw2333 at gmail.com>
Date: Thu, 1 Aug 2024 15:30:54 +0800
Subject: [PATCH 2/2] [SimplifyLibCalls] Add negative tests. NFC.

---
 llvm/test/Transforms/InstCombine/nan.ll | 29 +++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/llvm/test/Transforms/InstCombine/nan.ll b/llvm/test/Transforms/InstCombine/nan.ll
index fd4119bc0c06a..6745f6d1084e4 100644
--- a/llvm/test/Transforms/InstCombine/nan.ll
+++ b/llvm/test/Transforms/InstCombine/nan.ll
@@ -37,5 +37,34 @@ define float @nanf_empty() {
   ret float %res
 }
 
+; nagative tests
+
+define double @nan_poison() {
+; CHECK-LABEL: define double @nan_poison() {
+; CHECK-NEXT:    [[RES:%.*]] = call double @nan(ptr poison)
+; CHECK-NEXT:    ret double [[RES]]
+;
+  %res = call double @nan(ptr poison)
+  ret double %res
+}
+
+define double @nan_undef() {
+; CHECK-LABEL: define double @nan_undef() {
+; CHECK-NEXT:    [[RES:%.*]] = call double @nan(ptr undef)
+; CHECK-NEXT:    ret double [[RES]]
+;
+  %res = call double @nan(ptr undef)
+  ret double %res
+}
+
+define double @nan_null() {
+; CHECK-LABEL: define double @nan_null() {
+; CHECK-NEXT:    [[RES:%.*]] = call double @nan(ptr null)
+; CHECK-NEXT:    ret double [[RES]]
+;
+  %res = call double @nan(ptr null)
+  ret double %res
+}
+
 declare float @nanf(ptr)
 declare double @nan(ptr)



More information about the llvm-commits mailing list