[llvm] [CodeGen] Enhance inline asm constraint diagnostics (PR #101354)

[Eli Friedman via llvm-commits]

================
@@ -5034,7 +5034,8 @@ class TargetLowering : public TargetLoweringBase {
   /// returns a register number of 0 and a null register class pointer.
   virtual std::pair<unsigned, const TargetRegisterClass *>
   getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI,
-                               StringRef Constraint, MVT VT) const;
+                               StringRef Constraint, MVT VT,
+                               std::string &ErrMsg) const;
----------------
efriedma-quic wrote:

Maybe SmallStringImpl&?

I don't really see how you can do much better than that; an error message is, ultimately, just a string, given we don't support translation or anything like that.

https://github.com/llvm/llvm-project/pull/101354