[llvm] [Offload] Sanitize "standalone" unreachable instructions (PR #101425)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 31 15:28:46 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 9a1013220b668d846e63f241203b80515dee0a03 f91a4e7f848e1fc6e09492972ab50eb99eadac17 --extensions h,c,cpp -- llvm/include/llvm/Transforms/Instrumentation/OffloadSanitizer.h llvm/lib/Transforms/Instrumentation/OffloadSanitizer.cpp offload/DeviceRTL/src/Sanitizer.cpp offload/test/sanitizer/kernel_known_ub.c offload/test/sanitizer/kernel_trap.cpp offload/test/sanitizer/kernel_trap_all.c llvm/include/llvm/Frontend/OpenMP/OMP.h llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Frontend/OpenMP/OMP.cpp llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp offload/DeviceRTL/include/Utils.h offload/DeviceRTL/src/Utils.cpp offload/include/Shared/Environment.h offload/plugins-nextgen/common/include/ErrorReporting.h offload/plugins-nextgen/common/include/PluginInterface.h offload/plugins-nextgen/common/src/PluginInterface.cpp offload/test/sanitizer/kernel_crash.c offload/test/sanitizer/kernel_crash_async.c offload/test/sanitizer/kernel_crash_many.c offload/test/sanitizer/kernel_crash_single.c offload/test/sanitizer/kernel_trap.c offload/test/sanitizer/kernel_trap_async.c offload/test/sanitizer/kernel_trap_many.c
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/offload/plugins-nextgen/common/include/ErrorReporting.h b/offload/plugins-nextgen/common/include/ErrorReporting.h
index f27a6b8647..e81775b593 100644
--- a/offload/plugins-nextgen/common/include/ErrorReporting.h
+++ b/offload/plugins-nextgen/common/include/ErrorReporting.h
@@ -283,8 +283,8 @@ public:
break;
case SanitizerEnvironmentTy::UNREACHABLE:
reportError("execution reached an \"unreachable\" state (likely caused "
- "by undefined behavior)");
- break;
+ "by undefined behavior)");
+ break;
default:
reportError(
"execution stopped, reason is unknown due to invalid error code");
diff --git a/offload/test/sanitizer/kernel_trap.cpp b/offload/test/sanitizer/kernel_trap.cpp
index cef4d9737d..c7faf6b526 100644
--- a/offload/test/sanitizer/kernel_trap.cpp
+++ b/offload/test/sanitizer/kernel_trap.cpp
@@ -26,9 +26,7 @@ template <typename T> void cxx_function_name(int I, T *) {
#pragma omp target
{}
#pragma omp target
- {
- __builtin_trap();
- }
+ { __builtin_trap(); }
#pragma omp target
{}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/101425
More information about the llvm-commits
mailing list