[llvm] [SandboxIR] Implement SIToFPInst (PR #101374)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 12:06:52 PDT 2024


================
@@ -1378,6 +1380,27 @@ class CastInst : public Instruction {
 #endif
 };
 
+class SIToFPInst final : public CastInst {
----------------
vporpo wrote:

I could also try doing something similar for the tests, since there is a lot of repetition there too. The only downside is that if there is a failure the error reported won't be as easy to follow, but I doubt these tests will fail.

If we go this way, then the rest of the CastInst sub-classes can be a single PR which would be really nice.

Wdyt?

https://github.com/llvm/llvm-project/pull/101374


More information about the llvm-commits mailing list