[llvm] [Draft] Use TargetABI to assign default-target features in getDefaultSubtargetFeatures (PR #100833)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 31 10:56:39 PDT 2024
https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/100833
>From 087232c0db3b644579d557c6140d40e09576558c Mon Sep 17 00:00:00 2001
From: AdityaK <hiraditya at msn.com>
Date: Fri, 26 Jul 2024 14:22:40 -0700
Subject: [PATCH] Use TargetABI to assign default-target features in
getDefaultSubtargetFeatures
It is currently not possible to provide any reasonable
target-features for compiler generated functions (See: #69780)
Having a target-abi will provide a way to add minimal
requirements for target-features like `+d` for RISC-V.
---
.../llvm/LTO/legacy/ThinLTOCodeGenerator.h | 2 +-
.../llvm/TargetParser/SubtargetFeature.h | 2 +-
llvm/lib/LTO/LTOBackend.cpp | 6 +++++-
llvm/lib/LTO/LTOCodeGenerator.cpp | 6 +++++-
llvm/lib/LTO/LTOModule.cpp | 6 ++++--
llvm/lib/LTO/ThinLTOCodeGenerator.cpp | 20 +++++++++++++------
llvm/lib/TargetParser/SubtargetFeature.cpp | 5 ++++-
7 files changed, 34 insertions(+), 13 deletions(-)
diff --git a/llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h b/llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h
index f1337e82485c9..e9ff97053c107 100644
--- a/llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h
+++ b/llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h
@@ -40,7 +40,7 @@ struct TargetMachineBuilder {
std::optional<Reloc::Model> RelocModel;
CodeGenOptLevel CGOptLevel = CodeGenOptLevel::Aggressive;
- std::unique_ptr<TargetMachine> create() const;
+ std::unique_ptr<TargetMachine> create(const StringRef TargetABI) const;
};
/// This class define an interface similar to the LTOCodeGenerator, but adapted
diff --git a/llvm/include/llvm/TargetParser/SubtargetFeature.h b/llvm/include/llvm/TargetParser/SubtargetFeature.h
index 2e1f00dad2df3..0add2227098ed 100644
--- a/llvm/include/llvm/TargetParser/SubtargetFeature.h
+++ b/llvm/include/llvm/TargetParser/SubtargetFeature.h
@@ -195,7 +195,7 @@ class SubtargetFeatures {
void dump() const;
/// Adds the default features for the specified target triple.
- void getDefaultSubtargetFeatures(const Triple& Triple);
+ void getDefaultSubtargetFeatures(const Triple& Triple, const StringRef ABIInfo);
/// Determine if a feature has a flag; '+' or '-'
static bool hasFlag(StringRef Feature) {
diff --git a/llvm/lib/LTO/LTOBackend.cpp b/llvm/lib/LTO/LTOBackend.cpp
index effaed2d9bfb6..39c3fbcfc1167 100644
--- a/llvm/lib/LTO/LTOBackend.cpp
+++ b/llvm/lib/LTO/LTOBackend.cpp
@@ -201,7 +201,11 @@ static std::unique_ptr<TargetMachine>
createTargetMachine(const Config &Conf, const Target *TheTarget, Module &M) {
StringRef TheTriple = M.getTargetTriple();
SubtargetFeatures Features;
- Features.getDefaultSubtargetFeatures(Triple(TheTriple));
+ StringRef TargetABI = "";
+ if (auto TargetABIMD = dyn_cast_or_null<MDString>(M.getModuleFlag("target-abi")))
+ TargetABI = TargetABIMD->getString();
+
+ Features.getDefaultSubtargetFeatures(Triple(TheTriple), TargetABI);
for (const std::string &A : Conf.MAttrs)
Features.AddFeature(A);
diff --git a/llvm/lib/LTO/LTOCodeGenerator.cpp b/llvm/lib/LTO/LTOCodeGenerator.cpp
index 34aacb660144f..178a267cb0370 100644
--- a/llvm/lib/LTO/LTOCodeGenerator.cpp
+++ b/llvm/lib/LTO/LTOCodeGenerator.cpp
@@ -406,7 +406,11 @@ bool LTOCodeGenerator::determineTarget() {
// Construct LTOModule, hand over ownership of module and target. Use MAttr as
// the default set of features.
SubtargetFeatures Features(join(Config.MAttrs, ""));
- Features.getDefaultSubtargetFeatures(Triple);
+ StringRef TargetABI = "";
+ if (auto TargetABIMD = dyn_cast_or_null<MDString>(MergedModule->getModuleFlag("target-abi")))
+ TargetABI = TargetABIMD->getString();
+
+ Features.getDefaultSubtargetFeatures(Triple, TargetABI);
FeatureStr = Features.getString();
if (Config.CPU.empty())
Config.CPU = lto::getThinLTODefaultCPU(Triple);
diff --git a/llvm/lib/LTO/LTOModule.cpp b/llvm/lib/LTO/LTOModule.cpp
index eac78069f4d2b..fc9bc0e82327a 100644
--- a/llvm/lib/LTO/LTOModule.cpp
+++ b/llvm/lib/LTO/LTOModule.cpp
@@ -204,7 +204,9 @@ LTOModule::makeLTOModule(MemoryBufferRef Buffer, const TargetOptions &options,
if (TripleStr.empty())
TripleStr = sys::getDefaultTargetTriple();
llvm::Triple Triple(TripleStr);
-
+ StringRef TargetABI = "";
+ if (auto TargetABIMD = dyn_cast_or_null<MDString>(M->getModuleFlag("target-abi")))
+ TargetABI = TargetABIMD->getString();
// find machine architecture for this module
std::string errMsg;
const Target *march = TargetRegistry::lookupTarget(TripleStr, errMsg);
@@ -213,7 +215,7 @@ LTOModule::makeLTOModule(MemoryBufferRef Buffer, const TargetOptions &options,
// construct LTOModule, hand over ownership of module and target
SubtargetFeatures Features;
- Features.getDefaultSubtargetFeatures(Triple);
+ Features.getDefaultSubtargetFeatures(Triple, TargetABI);
std::string FeatureStr = Features.getString();
// Set a default CPU for Darwin triples.
std::string CPU;
diff --git a/llvm/lib/LTO/ThinLTOCodeGenerator.cpp b/llvm/lib/LTO/ThinLTOCodeGenerator.cpp
index 57c94e1988b79..5dd2632d88457 100644
--- a/llvm/lib/LTO/ThinLTOCodeGenerator.cpp
+++ b/llvm/lib/LTO/ThinLTOCodeGenerator.cpp
@@ -582,7 +582,7 @@ void ThinLTOCodeGenerator::crossReferenceSymbol(StringRef Name) {
}
// TargetMachine factory
-std::unique_ptr<TargetMachine> TargetMachineBuilder::create() const {
+std::unique_ptr<TargetMachine> TargetMachineBuilder::create(const StringRef TargetABI) const {
std::string ErrMsg;
const Target *TheTarget =
TargetRegistry::lookupTarget(TheTriple.str(), ErrMsg);
@@ -592,7 +592,7 @@ std::unique_ptr<TargetMachine> TargetMachineBuilder::create() const {
// Use MAttr as the default set of features.
SubtargetFeatures Features(MAttr);
- Features.getDefaultSubtargetFeatures(TheTriple);
+ Features.getDefaultSubtargetFeatures(TheTriple, TargetABI);
std::string FeatureStr = Features.getString();
std::unique_ptr<TargetMachine> TM(
@@ -918,9 +918,11 @@ void ThinLTOCodeGenerator::internalize(Module &TheModule,
*/
void ThinLTOCodeGenerator::optimize(Module &TheModule) {
initTMBuilder(TMBuilder, Triple(TheModule.getTargetTriple()));
-
+ StringRef TargetABI = "";
+ if (auto TargetABIMD = dyn_cast_or_null<MDString>(TheModule.getModuleFlag("target-abi")))
+ TargetABI = TargetABIMD->getString();
// Optimize now
- optimizeModule(TheModule, *TMBuilder.create(), OptLevel, Freestanding,
+ optimizeModule(TheModule, *TMBuilder.create(TargetABI), OptLevel, Freestanding,
DebugPassManager, nullptr);
}
@@ -996,8 +998,11 @@ void ThinLTOCodeGenerator::run() {
auto TheModule = loadModuleFromInput(Mod.get(), Context, false,
/*IsImporting*/ false);
+ StringRef TargetABI = "";
+ if (auto TargetABIMD = dyn_cast_or_null<MDString>(TheModule->getModuleFlag("target-abi")))
+ TargetABI = TargetABIMD->getString();
// CodeGen
- auto OutputBuffer = codegenModule(*TheModule, *TMBuilder.create());
+ auto OutputBuffer = codegenModule(*TheModule, *TMBuilder.create(TargetABI));
if (SavedObjectsDirectoryPath.empty())
ProducedBinaries[count] = std::move(OutputBuffer);
else
@@ -1185,9 +1190,12 @@ void ThinLTOCodeGenerator::run() {
saveTempBitcode(*TheModule, SaveTempsDir, count, ".0.original.bc");
auto &ImportList = ImportLists[ModuleIdentifier];
+ StringRef TargetABI = "";
+ if (auto TargetABIMD = dyn_cast_or_null<MDString>(TheModule->getModuleFlag("target-abi")))
+ TargetABI = TargetABIMD->getString();
// Run the main process now, and generates a binary
auto OutputBuffer = ProcessThinLTOModule(
- *TheModule, *Index, ModuleMap, *TMBuilder.create(), ImportList,
+ *TheModule, *Index, ModuleMap, *TMBuilder.create(TargetABI), ImportList,
ExportList, GUIDPreservedSymbols,
ModuleToDefinedGVSummaries[ModuleIdentifier], CacheOptions,
DisableCodeGen, SaveTempsDir, Freestanding, OptLevel, count,
diff --git a/llvm/lib/TargetParser/SubtargetFeature.cpp b/llvm/lib/TargetParser/SubtargetFeature.cpp
index 2c51c403c1934..d24bc951ba854 100644
--- a/llvm/lib/TargetParser/SubtargetFeature.cpp
+++ b/llvm/lib/TargetParser/SubtargetFeature.cpp
@@ -68,7 +68,7 @@ LLVM_DUMP_METHOD void SubtargetFeatures::dump() const {
}
#endif
-void SubtargetFeatures::getDefaultSubtargetFeatures(const Triple& Triple) {
+void SubtargetFeatures::getDefaultSubtargetFeatures(const Triple& Triple, const StringRef TargetABI) {
// FIXME: This is an inelegant way of specifying the features of a
// subtarget. It would be better if we could encode this information
// into the IR.
@@ -82,4 +82,7 @@ void SubtargetFeatures::getDefaultSubtargetFeatures(const Triple& Triple) {
AddFeature("altivec");
}
}
+ else if (Triple.isAndroid() && TargetABI.contains("lp64d")) {
+ AddFeature("+d");
+ }
}
More information about the llvm-commits
mailing list