[llvm] [BOLT][DWARF][NFC] Split DIEBuilder::finish (PR #101244)

[Alexander Yermolovich via llvm-commits]

================
@@ -761,10 +761,26 @@ void DWARFRewriter::updateDebugInfo() {
               : std::optional<std::string>(opts::DwarfOutputPath.c_str());
       std::string DWOName = DIEBlder.updateDWONameCompDir(
           *StrOffstsWriter, *StrWriter, *CU, DwarfOutputPath, std::nullopt);
+      auto DWODIEBuilderPtr = std::make_unique<DIEBuilder>(
+          BC, &(**SplitCU).getContext(), DebugNamesTable, CU);
+      DWODIEBuildersByCU.emplace_back(std::move(DWODIEBuilderPtr));
+      DIEBuilder &DWODIEBuilder = *DWODIEBuildersByCU.back().get();
       if (CU->getVersion() >= 5)
         StrOffstsWriter->finalizeSection(*CU, DIEBlder);
       processSplitCU(*CU, **SplitCU, DIEBlder, *TempRangesSectionWriter,
-                     AddressWriter, DWOName, DwarfOutputPath);
+                     AddressWriter, DWOName, DwarfOutputPath, DWODIEBuilder);
+    }
+    unsigned DWODIEBuilderIndex = 0;
+    for (DWARFUnit *CU : DIEBlder.getProcessedCUs()) {
----------------
ayermolo wrote:

Why not just iterate over DWODIEBuildersByCU directly?

https://github.com/llvm/llvm-project/pull/101244