[llvm] [BOLT][DWARF][NFC] Split DIEBuilder::finish (PR #101244)

Alexander Yermolovich via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 15:26:48 PDT 2024


================
@@ -535,11 +523,12 @@ void DIEBuilder::finish() {
     finalizeCU(*CU, TypeUnitStartOffset);
   }
 
+  uint64_t UnitSizes = UnitSize;
----------------
ayermolo wrote:

Let's just separate this into two variables.
One for computing CU offsets here, and another one for DebugNamesTable.
I think this kind of fragile to rely on updateDebugNamesTable to update UnitSize and to make sure for monolithic case it's invoked right after finish()

https://github.com/llvm/llvm-project/pull/101244


More information about the llvm-commits mailing list