[llvm] 5d833ee - [SCEV] Avoid unnecessary computeConstantDifference() call (NFC)

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2024-07-30T14:04:43+02:00
New Revision: 5d833ee6acc85bf108a8787ba233e955728868ab

URL: https://github.com/llvm/llvm-project/commit/5d833ee6acc85bf108a8787ba233e955728868ab
DIFF: https://github.com/llvm/llvm-project/commit/5d833ee6acc85bf108a8787ba233e955728868ab.diff

LOG: [SCEV] Avoid unnecessary computeConstantDifference() call (NFC)

No need to do the second one if the first one already failed.

Added: 
    

Modified: 
    llvm/lib/Analysis/ScalarEvolution.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp
index 51cffac808768..edd943d4eeea8 100644
--- a/llvm/lib/Analysis/ScalarEvolution.cpp
+++ b/llvm/lib/Analysis/ScalarEvolution.cpp
@@ -12098,8 +12098,10 @@ bool ScalarEvolution::isImpliedCondOperandsViaNoOverflow(
   // C)".
 
   std::optional<APInt> LDiff = computeConstantDifference(LHS, FoundLHS);
+  if (!LDiff)
+    return false;
   std::optional<APInt> RDiff = computeConstantDifference(RHS, FoundRHS);
-  if (!LDiff || !RDiff || *LDiff != *RDiff)
+  if (!RDiff || *LDiff != *RDiff)
     return false;
 
   if (LDiff->isMinValue())