[llvm] [Workflows] Enable commit access requests via GitHub issues (PR #100458)
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 29 14:47:27 PDT 2024
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/100458
>From 60ef4ac509016449dd9afb37c8cebfa82b94eab2 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Tue, 16 Jul 2024 19:50:51 +0000
Subject: [PATCH 1/2] [Workflows] Enable commit access requests via GitHub
issues
This updates the auto-labeler to match a specific issue title that
is going to be used for requesting commit access and then add the
infrastructure:commit-access-request label.
This will notify the admin team who will be able to handle the request.
See https://discourse.llvm.org/t/rfc-change-the-process-for-requesting-commit-access/80184
---
.github/new-issues-labeler.yml | 3 +++
llvm/docs/DeveloperPolicy.rst | 11 ++++++-----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/.github/new-issues-labeler.yml b/.github/new-issues-labeler.yml
index a5933d7fc9b37..028b7fbd5bdda 100644
--- a/.github/new-issues-labeler.yml
+++ b/.github/new-issues-labeler.yml
@@ -27,3 +27,6 @@
'bolt':
- '/\bbolt(?!\-)\b/i'
+
+'infrastructure:commit-access-request':
+ - '/Request Commit Access/'
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index f2ac46e6c04f2..95dd7251b4a13 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -476,11 +476,12 @@ Obtaining Commit Access
-----------------------
We grant commit access to contributors with a track record of submitting high
-quality patches. If you would like commit access, please send an email to
-`Chris <mailto:clattner at llvm.org>`_ with your GitHub username. This is true
-for former contributors with SVN access as well as new contributors. If
-approved, a GitHub invitation will be sent to your GitHub account. In case you
-don't get notification from GitHub, go to
+quality patches. If you would like commit access, please use this `link
+<https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
+and issue and request commit access. Replace the <user> string in the title
+with your github username, and explain why you are requesting commit access in
+the issue description. If approved, a GitHub invitation will be sent to your
+GitHub account. In case you don't get notification from GitHub, go to
`Invitation Link <https://github.com/orgs/llvm/invitation>`_ directly. Once
accept the invitation, you'll get commit access.
>From beda0a35441f5a21c6f55499b708db7377e2623d Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Mon, 29 Jul 2024 14:46:49 -0700
Subject: [PATCH 2/2] Address Review Comments:
* Shorten label name
* Fix typos
---
.github/new-issues-labeler.yml | 2 +-
llvm/docs/DeveloperPolicy.rst | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.github/new-issues-labeler.yml b/.github/new-issues-labeler.yml
index 028b7fbd5bdda..860535bbe3083 100644
--- a/.github/new-issues-labeler.yml
+++ b/.github/new-issues-labeler.yml
@@ -28,5 +28,5 @@
'bolt':
- '/\bbolt(?!\-)\b/i'
-'infrastructure:commit-access-request':
+'infra:commit-access-request':
- '/Request Commit Access/'
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 95dd7251b4a13..ac82a75d89474 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -478,12 +478,12 @@ Obtaining Commit Access
We grant commit access to contributors with a track record of submitting high
quality patches. If you would like commit access, please use this `link
<https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
-and issue and request commit access. Replace the <user> string in the title
+an issue and request commit access. Replace the <user> string in the title
with your github username, and explain why you are requesting commit access in
the issue description. If approved, a GitHub invitation will be sent to your
GitHub account. In case you don't get notification from GitHub, go to
`Invitation Link <https://github.com/orgs/llvm/invitation>`_ directly. Once
-accept the invitation, you'll get commit access.
+you accept the invitation, you'll get commit access.
Prior to obtaining commit access, it is common practice to request that
someone with commit access commits on your behalf. When doing so, please
More information about the llvm-commits
mailing list