[llvm] [SandboxIR] Added new StoreInst::create() functions with isVolatile arg (PR #100961)

via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 12:27:49 PDT 2024


================
@@ -810,10 +815,45 @@ define void @foo(i8 %val, ptr %ptr) {
   sandboxir::StoreInst *NewSt =
       sandboxir::StoreInst::create(Val, Ptr, Align(8),
                                    /*InsertBefore=*/Ret, Ctx);
+  // Check if create was volatile
----------------
vporpo wrote:

To keep things consistent we should either remove this comment, or add comments to the rest of the checks. Let's remove it for now. We can add the comments later in a separate PR if needed.

https://github.com/llvm/llvm-project/pull/100961


More information about the llvm-commits mailing list