[llvm] [llvm-mca] Add optional identifier field to mca::Instruction (PR #97867)

[Michael Maitland via llvm-commits]

michaelmaitland wrote:

> the value here is for llvm-mcad to explore whether receiving metadata is valuable. IIRC, the original providing metadata did not turn out to be useful

Sorry, I had it backwards with receiving and providing. My two "ideas" still hold if we swap receiving and providing around:

1. We hold off on taking this change until there is proof that llvm-mcad benefits from providing metadata. Otherwise, there are no known instances where this change is valuable. llvm-mcad can cherry pick this change on its own llvm branch during experiments.
2. We take this change since it is a small addition to the size of the object and non-invasive otherwise? Perhaps we can mark it as experimental, in the case that llvm-mcad providing metadata proves to not be useful (I.e. no known users of the field exist in the wild).


https://github.com/llvm/llvm-project/pull/97867