[compiler-rt] [sanitizer] Undef _TIME_BITS along with _FILE_OFFSET_BITS (PR #99699)

[Thomas Petazzoni via llvm-commits]

tpetazzoni wrote:

> Thanks for the patch. A couple of comments:

Thanks a lot for the quick feedback!

>     * You should request one or more reviewers (the last ones to review the file(s) in question are a good bet), otherwise the patch is most likely overlooked/ignored.  I only noticed it due to your equivalent `gcc-patches` post.

Thanks for noticing my patch then. It looks like you are the last person who made changes to this file, so I guess you're the right person to request a review from. I see @richlowe also contributed to this file 3 years ago.

>     * Please indicate which target (triple) you noticed the problem on and where/how you tested the patch.

The patch was actually tested on the GCC code base, when building an i686 glibc toolchain. But the problem exists for all 32-bit architectures for which libsanitizer has support for, when building with -D_TIME_BITS=64.

>     * The `#undef` needs a comment explaining why it's needed, especially given that this is a Solaris-specific file and Solaris doesn't have/care about `_TIME_BITS`.

It may be a Solaris-specific file, but it gets compiled unconditionally regardless of the current platform. I'll add a comment that explains things.

https://github.com/llvm/llvm-project/pull/99699