[compiler-rt] [sanitizer] Undef _TIME_BITS along with _FILE_OFFSET_BITS (PR #99699)
Rainer Orth via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 19 14:54:52 PDT 2024
rorth wrote:
Thanks for the patch. A couple of comments:
- You should request one or more reviewers (the last ones to review the file(s) in question are a good bet), otherwise the patch is most likely overlooked/ignored. I only noticed it due to your equivalent `gcc-patches` post.
- Please indicate which target (triple) you noticed the problem on and where/how you tested the patch.
- The `#undef` needs a comment explaining why it's needed, especially given that this is a Solaris-specific file and Solaris doesn't have/care about `_TIME_BITS`.
https://github.com/llvm/llvm-project/pull/99699
More information about the llvm-commits
mailing list