[llvm] [DebugInfo][InstrRef] Index DebugVariables and some DILocations (PR #99318)

Thu Jul 18 07:13:50 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-cmake-x86_64-avx512-linux` running on `avx512-intel64` while building `llvm` at step 7 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/1789

Here is the relevant piece of the build log for the reference:
```
Step 7 (ninja check 1) failure: stage 1 checked (failure)
...
[75/90] Linking CXX executable tools/clang/unittests/AST/Interp/InterpTests
[76/90] Linking CXX executable tools/clang/unittests/CrossTU/CrossTUTests
[77/90] Linking CXX executable tools/clang/unittests/ASTMatchers/ASTMatchersTests
[78/90] Linking CXX executable tools/clang/unittests/Analysis/FlowSensitive/ClangAnalysisFlowSensitiveTests
[79/90] Linking CXX executable tools/clang/unittests/Driver/ClangDriverTests
[80/90] Linking CXX executable unittests/ExecutionEngine/MCJIT/MCJITTests
[81/90] Linking CXX executable tools/clang/unittests/AST/ASTTests
[82/90] Linking CXX executable tools/clang/unittests/CodeGen/ClangCodeGenTests
[83/90] Linking CXX executable tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests
[84/90] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o
FAILED: unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iunittests/CodeGen -I/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen -Iinclude -I/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include -I/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/third-party/unittest/googletest/include -I/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/third-party/unittest/googlemock/include -march=cascadelake -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o -MF unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o.d -o unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o -c /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp: In member function ‘void InstrRefLDVTest::buildVLocValueMap(const llvm::DILocation*, const llvm::SmallSet<llvm::DebugVariable, 4>&, llvm::SmallPtrSetImpl<llvm::MachineBasicBlock*>&, LiveDebugValues::InstrRefBasedLDV::LiveInsT&, LiveDebugValues::FuncValueTable&, LiveDebugValues::FuncValueTable&, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>&)’:
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:224:35: error: cannot convert ‘const llvm::SmallSet<llvm::DebugVariable, 4>’ to ‘const llvm::SmallSet<unsigned int, 4>&’
  224 |     LDV->buildVLocValueMap(DILoc, VarsWeCareAbout, AssignBlocks, Output,
      |                                   ^~~~~~~~~~~~~~~
      |                                   |
      |                                   const llvm::SmallSet<llvm::DebugVariable, 4>
In file included from /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:27:
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1437:62: note:   initializing argument 2 of ‘void LiveDebugValues::InstrRefBasedLDV::buildVLocValueMap(const llvm::DILocation*, const llvm::SmallSet<unsigned int, 4>&, llvm::SmallPtrSetImpl<llvm::MachineBasicBlock*>&, LiveDebugValues::InstrRefBasedLDV::LiveInsT&, LiveDebugValues::FuncValueTable&, LiveDebugValues::FuncValueTable&, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>&)’
 1437 |                          const SmallSet<DebugVariableID, 4> &VarsWeCareAbout,
      |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp: In member function ‘virtual void InstrRefLDVTest_VLocSingleBlock_Test::TestBody()’:
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2649:50: error: no matching function for call to ‘LiveDebugValues::VLocTracker::VLocTracker(LiveDebugValues::OverlapMap&, llvm::DIExpression*&)’
 2649 |   VLocs.resize(1, VLocTracker(Overlaps, EmptyExpr));
      |                                                  ^
In file included from /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:27:
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1062:3: note: candidate: ‘LiveDebugValues::VLocTracker::VLocTracker(LiveDebugValues::DebugVariableMap&, const OverlapMap&, const llvm::DIExpression*)’
 1062 |   VLocTracker(DebugVariableMap &DVMap, const OverlapMap &O,
      |   ^~~~~~~~~~~
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1062:3: note:   candidate expects 3 arguments, 2 provided
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate: ‘LiveDebugValues::VLocTracker::VLocTracker(const LiveDebugValues::VLocTracker&)’
 1042 | class VLocTracker {
      |       ^~~~~~~~~~~
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note:   candidate expects 1 argument, 2 provided
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate: ‘LiveDebugValues::VLocTracker::VLocTracker(LiveDebugValues::VLocTracker&&)’
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note:   candidate expects 1 argument, 2 provided
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2661:23: error: no matching function for call to ‘llvm::MapVector<unsigned int, LiveDebugValues::DbgValue>::insert(<brace-enclosed initializer list>)’
 2661 |   VLocs[0].Vars.insert({Var, DbgValue(LiveInRspID, EmptyProps)});
      |   ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/llvm/MC/MCDwarf.h:17,
                 from /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/llvm/MC/MCContext.h:21,
                 from /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/llvm/CodeGen/MachineModuleInfo.h:36,
                 from /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:11:
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/llvm/ADT/MapVector.h:141:29: note: candidate: ‘std::pair<typename VectorType::iterator, bool> llvm::MapVector<KeyT, ValueT, MapType, VectorType>::insert(const std::pair<_T1, _T2>&) [with KeyT = unsigned int; ValueT = LiveDebugValues::DbgValue; MapType = llvm::DenseMap<unsigned int, unsigned int>; VectorType = llvm::SmallVector<std::pair<unsigned int, LiveDebugValues::DbgValue>, 0>; typename VectorType::iterator = std::pair<unsigned int, LiveDebugValues::DbgValue>*]’
  141 |   std::pair<iterator, bool> insert(const std::pair<KeyT, ValueT> &KV) {
      |                             ^~~~~~
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/include/llvm/ADT/MapVector.h:141:67: note:   no known conversion for argument 1 from ‘<brace-enclosed initializer list>’ to ‘const std::pair<unsigned int, LiveDebugValues::DbgValue>&’
  141 |   std::pair<iterator, bool> insert(const std::pair<KeyT, ValueT> &KV) {

```

https://github.com/llvm/llvm-project/pull/99318