[llvm] [DebugInfo][InstrRef] Index DebugVariables and some DILocations (PR #99318)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin` running on `doug-worker-3` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/1128

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
235.956 [2/9/5815] Linking CXX executable unittests/Transforms/Vectorize/VectorizeTests
235.998 [2/8/5816] Linking CXX static library lib/libbenchmark.a
236.018 [1/8/5817] Linking CXX static library lib/libbenchmark_main.a
236.057 [1/7/5818] Linking CXX executable unittests/Target/X86/X86Tests
236.097 [1/6/5819] Linking CXX executable unittests/Transforms/Utils/UtilsTests
236.143 [1/5/5820] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
236.315 [1/4/5821] Linking CXX executable unittests/tools/llvm-profdata/LLVMProfdataTests
236.679 [1/3/5822] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
236.785 [1/2/5823] Linking CXX executable unittests/tools/llvm-mca/LLVMMCATests
238.787 [1/1/5824] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o
FAILED: unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/local/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/buildbot/buildbot-root/x86_64-darwin/build/unittests/CodeGen -I/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/unittests/CodeGen -I/Users/buildbot/buildbot-root/x86_64-darwin/build/include -I/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include -I/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/third-party/unittest/googletest/include -I/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/third-party/unittest/googlemock/include -isystem /usr/local/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -O3 -DNDEBUG -std=c++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o -MF unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o.d -o unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o -c /Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:224:35: error: no viable conversion from 'const SmallSet<DebugVariable, [...]>' to 'const SmallSet<DebugVariableID, [...]>'
    LDV->buildVLocValueMap(DILoc, VarsWeCareAbout, AssignBlocks, Output,
                                  ^~~~~~~~~~~~~~~
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/llvm/ADT/SmallSet.h:135:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'const SmallSet<DebugVariable, 4>' to 'const llvm::SmallSet<unsigned int, 4> &' for 1st argument
class SmallSet {
      ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/llvm/ADT/SmallSet.h:135:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'const SmallSet<DebugVariable, 4>' to 'llvm::SmallSet<unsigned int, 4> &&' for 1st argument
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1437:62: note: passing argument to parameter 'VarsWeCareAbout' here
                         const SmallSet<DebugVariableID, 4> &VarsWeCareAbout,
                                                             ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2649:19: error: no matching constructor for initialization of 'VLocTracker'
  VLocs.resize(1, VLocTracker(Overlaps, EmptyExpr));
                  ^           ~~~~~~~~~~~~~~~~~~~
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class VLocTracker {
      ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1062:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
  VLocTracker(DebugVariableMap &DVMap, const OverlapMap &O,
  ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2661:17: error: no matching member function for call to 'insert'
  VLocs[0].Vars.insert({Var, DbgValue(LiveInRspID, EmptyProps)});
  ~~~~~~~~~~~~~~^~~~~~
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/llvm/ADT/MapVector.h:141:29: note: candidate function not viable: cannot convert initializer list argument to 'const std::pair<unsigned int, DbgValue>'
  std::pair<iterator, bool> insert(const std::pair<KeyT, ValueT> &KV) {
                            ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/llvm/ADT/MapVector.h:144:29: note: candidate function not viable: cannot convert initializer list argument to 'std::pair<unsigned int, DbgValue>'
  std::pair<iterator, bool> insert(std::pair<KeyT, ValueT> &&KV) {
                            ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2714:19: error: no matching constructor for initialization of 'VLocTracker'
  VLocs.resize(4, VLocTracker(Overlaps, EmptyExpr));
                  ^           ~~~~~~~~~~~~~~~~~~~
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class VLocTracker {
      ^
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
/Users/buildbot/buildbot-root/x86_64-darwin/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1062:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided

```

https://github.com/llvm/llvm-project/pull/99318