[llvm] [Xtensa] Implement lowering SELECT_CC, SETCC. (PR #97017)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 04:33:24 PDT 2024


================
@@ -1,10 +1,10 @@
 ; RUN: llc -march=xtensa < %s | FileCheck %s
 
-; CHECK-LABEL: brcc1:
+; CHECK-LABEL: brcc_sgt:
----------------
s-barannikov wrote:

It should never be hit, unless it is an XFAIL test.
>From my experience, adding -verify-machineinstrs to llc tests saves a lot of time catching bugs that otherwise could be caught only when building large applications.
Machine verifier is effectively `assert(mir.isValid())`, I don't see a reason why you woulndn't want this assert when running tests.

I don't insist though (I would if I were a maintainer of this backend).


https://github.com/llvm/llvm-project/pull/97017


More information about the llvm-commits mailing list