[llvm] [objcopy] Add aliases to some llvm-objcopy --subsystem options (PR #98036)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 00:22:57 PDT 2024


================
@@ -30,6 +30,15 @@
 # INVALID-MAJOR-NUMBER: 'foo' is not a valid subsystem major version
 # INVALID-MINOR-NUMBER: 'bar' is not a valid subsystem minor version
 
+# RUN: llvm-objcopy --subsystem=efi_application %t.in.exe
+# RUN: llvm-objcopy --subsystem=efi-app %t.in.exe
+
+# RUN: llvm-objcopy --subsystem=efi_boot_service_driver %t.in.exe
+# RUN: llvm-objcopy --subsystem=efi-bsd %t.in.exe
+
+# RUN: llvm-objcopy --subsystem=efi_runtime_driver %t.in.exe
+# RUN: llvm-objcopy --subsystem=efi-rtd %t.in.exe
----------------
jh7370 wrote:

I think you need to use llvm-readobj/FileCheck after each call to check the output file. Otherwise, this does nothing other than check that llvm-objcopy understands the value (but it might do absolutely nothing with it, for example). Once you do that, you should probably use a separate output file, so that you're not modifying the input in place, messing it up for other executions in the same test.

https://github.com/llvm/llvm-project/pull/98036


More information about the llvm-commits mailing list