[llvm] Make some tablegen tests more flexible. (PR #97651)

Wolfgang Pieb via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 09:31:35 PDT 2024


wolfy1961 wrote:

> LGTM
> 
> Do they fail sporadically, or are they just annoying to update? I'm wondering if we could write a small script to autogenerate the checks at some point, similar to update_test_checks

They're not flaky, just annoying to update. The output from tblgen seems to be deterministic. A script sounds like a good idea, but I'm wondering how much it would have to know about the inner workings of tblgen or at least the details of the table layout.

Thanks for the review.


https://github.com/llvm/llvm-project/pull/97651


More information about the llvm-commits mailing list